adding dispatch option for rendering build-collection#45
Merged
Conversation
Contributor
|
No spelling errors! 🎉 |
Contributor
|
No broken url errors! 🎉 |
Contributor
Author
|
@avahoffman wanted to make you aware of what I was doing. What do you think about having the build-collection.yml get triggered on a schedule (like the render-site.yml)? |
Contributor
|
Re-rendered previews from the latest commit:
Updated at 2025-05-12 with changes from b92adf5 |
Contributor
|
THanks! totally makes sense. |
Contributor
Author
|
@avahoffman i see now that it is triggered by the render-site.yml file |
Contributor
Author
|
so actually maybe we don't need this anymore |
Contributor
|
Ah yes, you're right, maybe we revert then? |
Contributor
Author
|
yup - im on it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the https://github.com/fhdsl/DaSL_Collection/actions/workflows/build-collection.yml has never run. The plan I think was to be triggered by the other workflows, but I may be misinterpreting.
I am adding a dispatch option in case we want to manually trigger (this is helpful for testing changes in the collection or the code to generate the collection). I wonder if a schedule makes sense for this workflow too (like the render wokflow).